LZ-624 Alternative Colony Nightmare Insert #3671
Conversation
|
You currently have a negative Fix/Feature pull request delta of -2. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score. |
|
Not sure what's causing the errors. |
|
Maps in working order now and the test errors are fixed. |
|
Van is back. Lets see if it works. |
Co-authored-by: Drathek <[email protected]>
|
Looks like the Van still has issues with being deleted. |
I only removed the van as a stop-gap. It seems there's a code issue with the game not properly deleting the van that is being overwritten by the nightmare insert. The rest of the map works from my testing. |
Try adding |
|
@morrowwolf ok. The issue really is, does the colony not only meet the standards of CM mapping, but is it worth having it as its own map variant? |
|
Assuming everything works, I think this is now a standalone map. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
|
The PR gave me some experience but I don't think this is to the standard to become a unique map. I'll likely revisit to add the hydro+medical as a nightmare insert in the future. |
#3883) # About the pull request This PR applies the fixes previously suggested for #3671. That PR was originally replacing much of the colony in a nightmare insert and it exposed how predator landmarks do not handle their area being changed and an issue with the van being replaced. The description made for these landmarks is based on some area information and that is used to index them. This PR makes it so the description of the landmark is saved so it can still be found in the list even if the area changes. # Explain why it's good for the game Less hard deletes and more futureproofing. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Put screenshots and videos here with an empty line between the screenshots and the `<details>` tags. </details> # Changelog :cl: Drathek, Steelpoint fix: Fixed possible hardeletes for predator landmarks and vehicles. Predator teleporation descriptions now do not change if the area is altered at runtime so they can still be found correctly. /:cl:
About the pull request
Adds a new map based off of LV-624, at this stage it only changes the main colony.
All equipment spawns, intel and akin are identical to LV-624's original colony.
I'm putting the map up for review to see where it stands.
Explain why it's good for the game
Varity is the spice of life. A new colony to play around in might help invigorate veteran players and those who feel a bit tired of the same map being used so often.
Testing Photographs and Procedure
Screenshot of the SDMM file of the map.
Screenshots & Videos
"Casualties of war"
Updated SDMM image as of: 26/06
Changelog
🆑
mapadd: New nightmare colony insert for LV-624 that replaces the colony with an entirely new version.
/:cl: